refactor inlist reading#970
Open
VincentVanlaer wants to merge 1 commit intomainfrom
Open
Conversation
VincentVanlaer
requested review from
Debraheem,
fxt44,
orlox,
rhdtownsend and
warrickball
as code owners
This commit introduces utils_namelist, which abstracts some of the common aspects of reading inlists in MESA (error message, nested inlists, ...). Previously, various different namelist reading routines were copied and modified around the code base. These have accrued various differences over time, which has been fixed now. The following behaviour has been changed: - pgbinary and pgstar no longer make MESA error when they are missing from inlists - it no longer matters where in the chain of inlist a namelist section is missing. It used to be that for certain section, only the first inline in a chain was allowed to have a missing section. - checks and copying of options only happens once all inlists have been read - failures when reading inlists will no longer dump a stack trace on the user
VincentVanlaer
force-pushed
the
refactor-inlist-reading
branch
from
d087069 to
fb1f429
Compare
Merged
Member
Author
|
The way I have implemented this is different from the usual way MESA is structured. Rather than having the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces utils_namelist, which abstracts some of the common aspects of reading inlists in MESA (error message, nested inlists, ...). Previously, various different namelist reading routines were copied and modified around the code base. These have accrued various differences over time, which has been fixed now.
The following behaviour has been changed: